-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
talkdesk 2.0.1 (new cask) #178047
talkdesk 2.0.1 (new cask) #178047
Conversation
It should be |
@krehel thank you for taking a look on this one! I referred to the vendor's documentation for the name, but having it just as "Talkdesk" should not cause any confusion - so I renamed it as per yours request. |
@@ -0,0 +1,29 @@ | |||
# https://support.talkdesk.com/hc/en-us/articles/13920616167963-Workspace-Desktop-App-for-Talkdesk-CX-Cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# https://support.talkdesk.com/hc/en-us/articles/13920616167963-Workspace-Desktop-App-for-Talkdesk-CX-Cloud |
verified: "td-infra-prd-us-east-1-s3-atlaselectron.s3.amazonaws.com/" | ||
name "Talkdesk Workspace Desktop for MacOS" | ||
desc "Desktop app that allows you to use Talkdesk as stand-alone software" | ||
homepage "https://www.mytalkdesk.com/atlas/download" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a better url that can be used for the Homepage?
I'm not sure this is ready for inclusion quite yet. Upstream appears to have some issues to work out. I installed the version in this Cask, and it immediately force "updated" to version So this needs to go back to |
@DanzigerGeist - thanks for opening this, but I'm closing it for now as this version in the PR seems unstable, and the replacement version does not seem to work for me. Please feel free to open this back up when and if this software stabilizes. |
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>
worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.NOTE: Running
brew audit --cask --new <cask>
throws a warning: "cask token mentions desktop". I would like to request an exception since the official application name is Talkdesk Desktop.