Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

talkdesk 2.0.1 (new cask) #178047

Closed
wants to merge 3 commits into from

Conversation

DanzigerGeist
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

NOTE: Running brew audit --cask --new <cask> throws a warning: "cask token mentions desktop". I would like to request an exception since the official application name is Talkdesk Desktop.

@DanzigerGeist DanzigerGeist changed the title talkdesk-desktop 2.0.1 talkdesk-desktop 2.0.1 (new cask) Jun 28, 2024
@krehel
Copy link
Member

krehel commented Jun 28, 2024

NOTE: Running brew audit --cask --new <cask> throws a warning: "cask token mentions desktop". I would like to request an exception since the official application name is Talkdesk Desktop.

It should be talkdesk because the app block is Talkdesk.app. The DMG's in the Electron feed also refer to it as Talkdesk.

@DanzigerGeist DanzigerGeist changed the title talkdesk-desktop 2.0.1 (new cask) talkdesk2.0.1 (new cask) Jun 28, 2024
@DanzigerGeist DanzigerGeist changed the title talkdesk2.0.1 (new cask) talkdesk 2.0.1 (new cask) Jun 28, 2024
@DanzigerGeist
Copy link
Contributor Author

@krehel thank you for taking a look on this one! I referred to the vendor's documentation for the name, but having it just as "Talkdesk" should not cause any confusion - so I renamed it as per yours request.

@@ -0,0 +1,29 @@
# https://support.talkdesk.com/hc/en-us/articles/13920616167963-Workspace-Desktop-App-for-Talkdesk-CX-Cloud
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# https://support.talkdesk.com/hc/en-us/articles/13920616167963-Workspace-Desktop-App-for-Talkdesk-CX-Cloud

verified: "td-infra-prd-us-east-1-s3-atlaselectron.s3.amazonaws.com/"
name "Talkdesk Workspace Desktop for MacOS"
desc "Desktop app that allows you to use Talkdesk as stand-alone software"
homepage "https://www.mytalkdesk.com/atlas/download"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better url that can be used for the Homepage?

@p-linnane p-linnane added the awaiting user reply Issue needs response from a user. label Jul 3, 2024
@krehel
Copy link
Member

krehel commented Jul 3, 2024

I'm not sure this is ready for inclusion quite yet. Upstream appears to have some issues to work out.

I installed the version in this Cask, and it immediately force "updated" to version 1.12, which does not seem to work in my VM.

So this needs to go back to 1.12 at least if the version here is considered unusable, and if 1.12 crashes then this should be tabled until some stability is in this app.

@krehel
Copy link
Member

krehel commented Jul 5, 2024

@DanzigerGeist - thanks for opening this, but I'm closing it for now as this version in the PR seems unstable, and the replacement version does not seem to work for me. Please feel free to open this back up when and if this software stabilizes.

@krehel krehel closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip awaiting user reply Issue needs response from a user. new cask
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants